Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native] Advance Velox and corresponding unit test updates #24324

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zation99
Copy link
Contributor

@zation99 zation99 commented Jan 6, 2025

Description

It's a follow up from facebookincubator/velox#12014 which changed namespace naming in cursor.h.
The Presto tests are updated together with Velox version advance.

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@zation99 zation99 requested a review from a team as a code owner January 6, 2025 20:24
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Jan 6, 2025
tanjialiang
tanjialiang previously approved these changes Jan 6, 2025
@zation99 zation99 force-pushed the jiaqizhang_advance_velox_unittest branch from ea39f31 to af0fb6c Compare January 6, 2025 21:35
@aditi-pandit aditi-pandit changed the title [native] Advance Velox and adjust presto unit tests accordingly [native] Advance Velox Jan 6, 2025
Copy link
Contributor

@aditi-pandit aditi-pandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zation99

@zation99 zation99 changed the title [native] Advance Velox [native] Advance Velox and corresponding unit test updates Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:Meta PR from Meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants