-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show security mode in SHOW CREATE VIEW #24297
base: master
Are you sure you want to change the base?
Show security mode in SHOW CREATE VIEW #24297
Conversation
@@ -1202,7 +1202,7 @@ public void testCreateAlterTable() | |||
public void testCreateDropView() | |||
{ | |||
// create table with default format orc | |||
String createViewSql = "CREATE VIEW hive.hive_test.hive_view AS\n" + | |||
String createViewSql = "CREATE VIEW hive.hive_test.hive_view SECURITY DEFINER AS\n" + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add extra space after DEFINER
"SELECT *\n" + | ||
"FROM\n" + | ||
" orders", schemaName)); | ||
.isEqualTo(format("CREATE VIEW iceberg.\"%s\".view_orders SECURITY %s AS\n" + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add extra space after %s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead can you fix the formatting from the SqlFormatter so that there is only one space before/after.
Also, please squash your commits together and improve the commit message title to be more specific e.g. |
Description
T211135818
Currently, show create view does not include the security mode that was used at the time the view was defined.
Motivation and Context
Impact
Test Plan
Manual testing on maven artifact version
0.291-20241230.214957-185
on verifier clusterftw3_verifier_t10_2
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
If release note is NOT required, use: