-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core support for enums, take #2 #15219
Conversation
@rongrong I also added another new commit to the stack: Move enum parametric types to presto-common I could also blend these last 3 "fix" commits into the earlier commits but I figured that since the stack had already been merged into master and reverted, it might be clearer to leave the fixes as separate commits? |
presto-common/src/test/java/com/facebook/presto/common/type/BenchmarkTypeSignatureParsing.java
Show resolved
Hide resolved
We already reverted the previous commits so let's just try to go clean and make each commit as bug-free as possible. It's easier to review the changes this way, but when we are ready to merge, please merge the new commits with the original ones introducing the change. |
Add an is-a constraint for type variables, so we can describe generic types of a certain kind.
54f1ae5
to
2f83a7d
Compare
OK, I combined the last 3 commits into the earlier ones (that includes your fix to the TreeRewriter) |
@yingsu00 @caithagoras We fixed the regression and added a benchmark to test |
presto-common/src/test/java/com/facebook/presto/common/type/BenchmarkTypeSignatureParsing.java
Outdated
Show resolved
Hide resolved
presto-common/src/test/java/com/facebook/presto/common/type/BenchmarkTypeSignatureParsing.java
Show resolved
Hide resolved
Support common operators like `=` on enum types
2f83a7d
to
e9fadc8
Compare
Second attempt to merge #14728
This was previously reverted because of a performance regression detected in
TypeSignature.parseTypeSignature
This regression is addressed in a newly added commit, which includes a benchmark.
Performance stats on BenchmarkTypeSignatureParsing are as follows on my machine: