Fix encrypt large value #15199
Merged
Fix encrypt large value #15199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschlussel
force-pushed
the
fix-encrypt-large-value
branch
from
a7fe457 to
ccca045
Compare
rschlussel
commented
Sep 21, 2020
|
|
||
| Random rnd = new Random(0); | ||
| String val = rnd.doubles(50_000).mapToObj(Double::toString).collect(Collectors.joining(",")); | ||
| tester.assertRoundTrip( |
There was a problem hiding this comment.
this test doesn't use testRoundTrip() because there is some bug with the hive reader reading the list value test (unrelated to encryption)
sdruzkin
approved these changes
Sep 21, 2020
| length = chunk.length; | ||
| offset = 0; | ||
| // size after encryption should not exceed what the 3 byte header can hold (2^23) | ||
| if (length > 8388608) { | ||
| throw new OrcEncryptionException("Encrypted data size %s exceeds limit of 2^23 %s", length); |
There was a problem hiding this comment.
The message has two %s placeholders, it should either have two length arguments or not have the last %s.
There was a problem hiding this comment.
good catch, thank you!
rschlussel
force-pushed
the
fix-encrypt-large-value
branch
from
f83e4b6 to
3022887
Compare
mbasmanova
approved these changes
Sep 22, 2020
mbasmanova
reviewed
Sep 22, 2020
We were using the incorrect offsets for the data we were encrypting and for the output buffer
rschlussel
force-pushed
the
fix-encrypt-large-value
branch
from
3022887 to
217e24b
Compare
This was referenced Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan - new unit test in AbstractTestOrcReader