[Verifier] Add application-name config #15191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #15175 |
palashgoel7
force-pushed
the
verifier-application-name
branch
from
f82583f to
b6f1b28
Compare
|
@caithagoras Could you please review this? |
|
Looks like the 2nd commit is updating the part of the documentation that is just updated in the 1st commit. We should avoid that. For this case, we can just merge the 2nd commit into the 1st. |
caithagoras
approved these changes
Sep 22, 2020
|
Thank you for contributing. I'll merge once the comment is addressed. |
palashgoel7
force-pushed
the
verifier-application-name
branch
from
b6f1b28 to
897eb67
Compare
|
@caithagoras Thanks for reviewing my work. I have fixed the issue. |
This was referenced Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan - (Please fill in how you tested your changes)
Verified Jar is created and works with config in Docs. Also, verified generated config in logs.
Please make sure your submission complies with our Development, Formatting, and Commit Message guidelines.
Fill in the release notes towards the bottom of the PR description.
See Release Notes Guidelines for details.