Fix LimitQueryDeterminismAnalyzer #15181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yingsu00
approved these changes
Sep 16, 2020
sujay-jain
reviewed
Sep 16, 2020
| @@ -262,7 +268,7 @@ private LimitQueryDeterminismAnalysis analyzeLimitNoOrderBy(Query newLimitQuery, | |||
| if (rowCountHigherLimit == rowCount) { | |||
| return DETERMINISTIC; | |||
| } | |||
| if (rowCount >= limit && rowCountHigherLimit > rowCount) { | |||
There was a problem hiding this comment.
why are we removingrowCount >= limit check? It makes sense to be non-deterministic in this case as well.
There was a problem hiding this comment.
The change we're adding in this PR will short circuit cases with rowCount < limit. Therefore, when reaching this line, it is guaranteed that rowCount >= limit.
sujay-jain
approved these changes
Sep 16, 2020
Fix LimitQueryDeterminismAnalyzer to return DETERMINISTIC when row count from the control query is less then the limit of the limit clause. Before the fix, LimitQueryDeterminismAnalyzer concluded ANALYSIS_FAILED_DATA_CHANGED instead.
This was referenced Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix LimitQueryDeterminismAnalyzer to return
DETERMINISTICwhen the control query row count is less then the value of the limit clause. Before the fix, LimitQueryDeterminismAnalyzer concludedANALYSIS_FAILED_DATA_CHANGEDinstead where there the data is not actually changed.