Support smallint, tinyint, date type of Cassandra #15147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SandishKumarHN
force-pushed
the
CassandraSupportSmallInt
branch
from
8d3ebef to
f069ba4
Compare
fgwang7w
reviewed
Sep 16, 2020
| @@ -127,6 +134,8 @@ public static CassandraType getCassandraType(DataType.Name name) | |||
| return COUNTER; | |||
| case CUSTOM: | |||
| return CUSTOM; | |||
| case DATE: | |||
There was a problem hiding this comment.
better to document these types support in cassandra.rst
SandishKumarHN
force-pushed
the
CassandraSupportSmallInt
branch
2 times, most recently
from
30e6cf7 to
e5d59c4
Compare
|
|
|
LGTM. I'd defer to @highker if there's any more comments. |
@fgwang7w the integration test failure is not related to PR. |
highker
approved these changes
Sep 16, 2020
Comment on lines
88
to
91
| this.toCassandraDate = value -> DATE_FORMATTER.print(TimeUnit.DAYS.toMillis(value)); | ||
| } | ||
| else { | ||
| this.toCassandraDate = value -> LocalDate.fromDaysSinceEpoch(toIntExact(value)); |
|
and squash two commits into one? |
SandishKumarHN
force-pushed
the
CassandraSupportSmallInt
branch
from
f2c8b9e to
03becae
Compare
@highker done, and CI failure is not related to the PR. |
|
Unfortunately this has resurfaced the joda libraries which were taken out in #14046 :( |
This was referenced Oct 6, 2020
v-jizhang
added a commit
to v-jizhang/presto
that referenced
this pull request
May 24, 2021
Cherry-pick of trinodb/trino#141. This is also a fix for prestodb#15147 which tried to backport Trino prestodb#141 but that backporting was incomplete and caused the Cassandra tests to fail. Resolves: prestodb#15749 Co-authored-by: Yuya Ebihara <ebyhry@gmail.com>
highker
pushed a commit
that referenced
this pull request
May 25, 2021
Cherry-pick of trinodb/trino#141. This is also a fix for #15147 which tried to backport Trino #141 but that backporting was incomplete and caused the Cassandra tests to fail. Resolves: #15749 Co-authored-by: Yuya Ebihara <ebyhry@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support smallint, tinyint, date type of Cassandra