-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Support for user-defined enums #14691
Closed
Closed
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
fd40b7b
add IntegerEnumType
daniel-ohayon 6f3beeb
add StringEnumType
daniel-ohayon 0df59a1
dynamic cast functions for string/int -> enum
daniel-ohayon 8ee5838
generate enum cast functions on-the-fly in BuiltinFunctionNamespaceMa…
daniel-ohayon 39b3788
provide user-defined types via FunctionNamespaceManager
daniel-ohayon 8676ae6
tests for enum casts
daniel-ohayon a6a61de
expose enum metadata to client, use it for serDe
daniel-ohayon f4d1c62
fix cast return type; implement missing getTypeMetadata for enums
daniel-ohayon c3c2619
fix checkstyle violation
daniel-ohayon e60ac30
handle hive serialization
daniel-ohayon 2ccd5d1
display enum keys in CLI output
daniel-ohayon a47cf26
enforce distinct values for enums
daniel-ohayon 11ecc02
support more standard operators for enums
daniel-ohayon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
53 changes: 53 additions & 0 deletions
53
presto-common/src/main/java/com/facebook/presto/common/type/StringEnumType.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
/* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package com.facebook.presto.common.type; | ||
|
||
import java.util.Map; | ||
|
||
public class StringEnumType | ||
extends VarcharType | ||
implements EnumType<String> | ||
{ | ||
private final Map<String, String> entries; | ||
|
||
public StringEnumType(String name, Map<String, String> entries) | ||
{ | ||
super(VarcharType.MAX_LENGTH, TypeSignature.parseTypeSignature(name)); | ||
this.entries = entries; | ||
} | ||
|
||
@Override | ||
public Map<String, String> getEntries() | ||
{ | ||
return entries; | ||
} | ||
|
||
@Override | ||
public boolean isOrderable() | ||
{ | ||
return false; | ||
} | ||
|
||
@Override | ||
public boolean isComparable() | ||
{ | ||
return false; | ||
} | ||
|
||
@Override | ||
public Type getValueType() | ||
{ | ||
return VarcharType.VARCHAR; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably want to refactor
VarcharType
intoAbstractVarcharType
andVarcharType
(similar toAbstractLongType
andBigintType
) and keep this as final. That way you also avoid the weird need to provide a type signature for the constructor.