Minor fixes in Verifier

prestodb · Sep 10, 2020 · aae0157 · aae0157
1 parent f3a43a8
commit aae0157
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 22 deletions.
diff --git a/...o-verifier/src/main/java/com/facebook/presto/verifier/framework/AbstractVerification.java b/...o-verifier/src/main/java/com/facebook/presto/verifier/framework/AbstractVerification.java
@@ -214,20 +214,18 @@ public VerificationResult run()
             }
         }
 
-        return
-
-                concludeVerification(
-                        partialResult.get(),
-                        control,
-                        test,
-                        controlQueryContext,
-                        testQueryContext,
-                        matchResult,
-                        determinismAnalysis,
-                        controlChecksumQueryContext,
-                        testChecksumQueryContext,
-                        determinismAnalysisDetails.build(),
-                        throwable);
+        return concludeVerification(
+                partialResult.get(),
+                control,
+                test,
+                controlQueryContext,
+                testQueryContext,
+                matchResult,
+                determinismAnalysis,
+                controlChecksumQueryContext,
+                testChecksumQueryContext,
+                determinismAnalysisDetails.build(),
+                throwable);
     }
 
     private Optional<String> resolveFailure(

diff --git a/...to-verifier/src/main/java/com/facebook/presto/verifier/framework/VerificationManager.java b/...to-verifier/src/main/java/com/facebook/presto/verifier/framework/VerificationManager.java
@@ -81,12 +81,12 @@ public class VerificationManager
     private final int maxConcurrency;
     private final int suiteRepetitions;
     private final int queryRepetitions;
-    private int verificationResubmissionLimit;
-    private boolean skipControl;
+    private final int verificationResubmissionLimit;
+    private final boolean skipControl;
 
-    private ExecutorService executor;
-    private CompletionService<VerificationResult> completionService;
-    private AtomicInteger queriesSubmitted = new AtomicInteger();
+    private final ExecutorService executor;
+    private final CompletionService<VerificationResult> completionService;
+    private final AtomicInteger queriesSubmitted = new AtomicInteger();
 
     @Inject
     public VerificationManager(
@@ -117,14 +117,14 @@ public VerificationManager(
         this.queryRepetitions = config.getQueryRepetitions();
         this.verificationResubmissionLimit = config.getVerificationResubmissionLimit();
         this.skipControl = config.isSkipControl();
+
+        this.executor = newFixedThreadPool(maxConcurrency);
+        this.completionService = new ExecutorCompletionService<>(executor);
     }
 
     @PostConstruct
     public void start()
     {
-        this.executor = newFixedThreadPool(maxConcurrency);
-        this.completionService = new ExecutorCompletionService<>(executor);
-
         List<SourceQuery> sourceQueries = sourceQuerySupplier.get();
         log.info("Total Queries: %s", sourceQueries.size());
         sourceQueries = applyOverrides(sourceQueries);