Skip to content

Commit

Permalink
Fix CI for next snapshot iteration PRs
Browse files Browse the repository at this point in the history
The new release process for presto creates pull requests
that have an incremented snapshot which hasn't
been built by anything yet. There are tests that are building
test coverage but skipping presto server. This creates a problem
where they are requesting dependencies that aren't built yet.

We don't need test-coverage in these tests, so it's best if
we just skip building those modules.
  • Loading branch information
g1y committed Nov 2, 2022
1 parent 96180d8 commit 55e2523
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/maven-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ jobs:
- name: Maven Checks
run: |
export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
./mvnw install -B -V -T C1 -DskipTests -P ci -pl '!:presto-server-rpm'
./mvnw install -B -V -T C1 -DskipTests -P ci -pl '!:presto-server-rpm,!presto-test-coverage'
- name: Test Server RPM
run: |
export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
./mvnw verify -B -P ci -pl :presto-server-rpm
- name: Clean Maven Output
run: ./mvnw clean -pl '!:presto-server,!:presto-cli'
run: ./mvnw clean -pl '!:presto-server,!:presto-cli,!presto-test-coverage'
2 changes: 1 addition & 1 deletion .github/workflows/product-tests-specific-environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
- name: Maven install
run: |
export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
./mvnw install ${MAVEN_FAST_INSTALL} -am -pl '!presto-docs,!presto-server-rpm,!presto-spark-package,!presto-spark-launcher,!presto-spark-testing'
./mvnw install ${MAVEN_FAST_INSTALL} -am -pl '!presto-docs,!presto-server-rpm,!presto-spark-package,!presto-spark-launcher,!presto-spark-testing,!presto-test-coverage'
- name: Product Tests Specific 2.1
run: presto-product-tests/bin/run_on_docker.sh singlenode-ldap -g ldap -x simba_jdbc
# SQL server image sporadically hangs during the startup
Expand Down

0 comments on commit 55e2523

Please sign in to comment.