feat: decouple SQL parser debug logs and add -debug flag#1040
Open
pivaldi wants to merge 1 commit intopressly:mainfrom
Open
feat: decouple SQL parser debug logs and add -debug flag#1040pivaldi wants to merge 1 commit intopressly:mainfrom
pivaldi wants to merge 1 commit intopressly:mainfrom
Conversation
This change separates the internal SQL parser state machine logs from the standard verbose output. Key changes: - Introduced `goose.SetDebug(bool)` and `internalDebug` flag to control low-level parser logging independently of `SetVerbose`. - Refactored `internal/sqlparser.ParseSQLMigration` to accept an optional logger interface, removing its hard dependency on the global `log` package. - Enhanced `goose.Logger` interface with `Println` to ensure compatibility with the refactored parser and provide a more complete logging contract. - Added a `-debug` flag to the goose CLI and `WithDebug` to `ProviderOption`. - Updated all internal calls to the SQL parser to propagate the debug flag and the configured logger. Users can now see executed SQL statements using `-v` without the "StateMachine" noise, while still being able to opt-in to full debug information using `-debug`.
pivaldi
added a commit
to pivaldi/mmw-todo
that referenced
this pull request
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change separates the internal SQL parser state machine logs from the standard verbose output.
Key changes:
goose.SetDebug(bool)andinternalDebugflag to control low-level parser logging independently ofSetVerbose.internal/sqlparser.ParseSQLMigrationto accept an optional logger interface, removing its hard dependency on the globallogpackage.goose.Loggerinterface withPrintlnto ensure compatibility with the refactored parser and provide a more complete logging contract.-debugflag to the goose CLI andWithDebugtoProviderOption.Users can now see executed SQL statements using
-vwithout the "StateMachine" noise, while still being able to opt-in to full debug information using-debug.