Skip to content

Issue #227: Fix code quality issues #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2016
Merged

Issue #227: Fix code quality issues #228

merged 2 commits into from
Apr 21, 2016

Conversation

promulo
Copy link
Contributor

@promulo promulo commented Apr 12, 2016

Hello,

I took the liberty to tackle some of the issues pointed by the report mentioned on #227.

Thanks for reviewing! :)

@calind
Copy link
Contributor

calind commented Apr 21, 2016

LGTM. ping @vtemian

@vtemian
Copy link
Contributor

vtemian commented Apr 21, 2016 •
edited
Loading

LGTM. Thanks @promulo

@vtemian vtemian merged commit e62f3a0 into presslabs:master Apr 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@promulo @calind @vtemian @pdobrescu