Revert "refactor: Execute autocmd in group scope" #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 18ed14a. Do not need "augroup" for "ftdetect", see :h ftdetect, and "filetypedetect" may is a autocmd group name.
alerque
requested changes
Feb 22, 2022
There was a problem hiding this comment.
Thanks, I recently learned this lesson the hard way on another project.
The only thing is this is going to throw a lint error from vint. We'll need to add a comment to tell the linter to ignore that rule for this file. Here is an example:
https://github.com/sile-typesetter/vim-sile/blob/master/ftdetect/sile.vim#L7
alerque
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 18ed14a.
Do not need
augroupforftdetect, see:h ftdetect, andfiletypedetectmay is a autocmd group name.