BUGFIX: Unstable behavior in the "getPath()" method #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 6, 2018 08:35
No functional changes here. Only style improvements were made.
No functional changes here.
lifecrisis
changed the title
lifecrisis
changed the title
This commit prevents "NERDTreeUI.getPath()" from returning a "Path" object even when no tree node was selected. Previously, positioning your cursor on one of the blank lines above the tree and running... :echo g:NERDTreeFileNode.GetSelected() ... could potentially return the path for the current working directory (your working directory needs to be under the tree root). This is because the constructor for "Path" objects returns a "Path" for the current working directory when passed an empty string. So, we need to short circuit the "getPath()" function for lines that cannot possibly be tree nodes. This solves the problem for "GetSelected()" because that method uses the "getPath()" method from the "UI" class to do its work. Note that this bug only presented for me on *nix systems.
PhilRunninger
approved these changes
Jan 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to a number of style improvements, this PR fixes some unstable behavior for the
NERDTreeUI.getPath()method.To replicate the problem on *nix systems:
:echo b:NERDTree.ui.getPath(line('.'))to see that the wrong value is returned (this only works if the working directory is at or beneath the NERDTree root).This problem doesn't exist on Windows from what I can tell.