fix Object.assign on state #24
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can verify that this fixes it. Great find! I immediately ran against this :) hard to debug! Perhaps some of the examples could use a integration test? |
|
I was receiving an error that Will see if I was doing something wrong, but I totally agree with this change (which is why I have the comment of me doing that still in there). |
|
In testing these changes now with the samples I still saw the state.setIn is not a function error. I believe have found a solution now though, and will be publishing it soon. |
Merged
prescottprue
added a commit
that referenced
this pull request
Sep 1, 2016
* Fixes #23 with code similar to #24 (Object.assign removed from reducer) * Provider auth action now correctly creates authProvider and includes email scope * Google Signup/Login in material example * Provider login creates profile * Unauthorized error added to handle failed read/writes * `README.md` updated with version number and contributors
xymw
pushed a commit
to xymw/redux-firebasev3
that referenced
this pull request
Apr 30, 2017
* Populate section added to recipes * Profile Params list populate added to roadmap to address prescottprue#24 * firebase-admin support added to roadmap to address prescottprue#22 * AuthRequired and Loading decorators added to roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #23