feat(auth): github OAuth provider option in login #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…case provider name | check for apple.com | pass down providerName to OAuthProvider when microsoft or apple | added apple to supportedAuthProviders
Codecov Report
@@ Coverage Diff @@
## master #986 +/- ##
==========================================
+ Coverage 88.33% 88.34% +0.01%
==========================================
Files 29 29
Lines 797 798 +1
==========================================
+ Hits 704 705 +1
Misses 93 93 |
davidepalazzo
changed the title
| const lowerCaseProviderName = providerName.toLowerCase() | ||
|
|
||
| if ( | ||
| lowerCaseProviderName === 'microsoft.com' || |
There was a problem hiding this comment.
Most likely going to update this to be an array instead of multiple if conditions since that will also make it easy to add to the list:
['microsoft.com', 'apple.com', 'yahoo.com'].includes(lowerCaseProviderName)
|
It definetly does help thanks! Really glad to hear that the package has been useful to you |
prescottprue
added a commit
that referenced
this pull request
Jul 26, 2020
* feat(populate): added support for `storeAs` when populating child from redux - @nagarjuna993 * fix(types): change `updateProfile` return type (#975) - @nikitakost * feat(auth): github OAuth provider option in login (#986) - @davidepalazzo * chore(deps): update babel dev dependencies to ^7.10.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hey there, this PR is for #971. I stumbled across this issue and since I'm working on a project that uses the Apple auth I thought it would have been worth it to add the other providers too.
The main addition in this PR is the provider type for the Credentials. I edited
createAuthProviderto account for apple.com and yahoo.com and added it tosupportedAuthProviders.The unit test has been updated also to reflect the addition I made.
It's not a big one but hopefully it helps. Btw, I started using this package a couple of months ago and I'm loving it so far.
Let me know if there's anything that might need changing. Cheers.
Check List
If not relevant to pull request, check off as complete
Relevant Issues
#971