feat(types): generic types for firestore methods #920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #920 +/- ##
=======================================
Coverage 88.87% 88.87%
=======================================
Files 29 29
Lines 791 791
=======================================
Hits 703 703
Misses 88 88 |
|
Nice work! Thanks for taking the time to add this |
prescottprue
changed the title
prescottprue
added a commit
that referenced
this pull request
May 2, 2020
* chore(ci): add package version check stage to prevent failed builds if version is already released * feat(types): generic types for firestore methods (#920) - @puppybits * fix(types): use correct import for react in types (#927) - @loginov-rocks * chore(types): remove unused AppTypes import Co-authored-by: Bobby <bobby@getfiskal.com> Co-authored-by: Danila Loginov <danila@loginov.rocks>
prescottprue
added a commit
that referenced
this pull request
May 2, 2020
* chore(ci): add package version check stage to prevent failed builds if version is already released * feat(types): generic types for firestore methods (#920) - @puppybits * fix(types): use correct import for react in types (#927) - @loginov-rocks * chore(types): remove unused AppTypes import Co-authored-by: Bobby <bobby@getfiskal.com> Co-authored-by: Danila Loginov <danila@loginov.rocks>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Firestore types update
Check List
If not relevant to pull request, check off as complete
Relevant Issues