fix(firebaseConnect): move hoistStatics to allow static methods to be copied - @jeloagnasin

[jeloagnasin]

Description

Fixes #732

Check List

If not relevant to pull request, check off as complete

• All tests passing
• Docs updated with any changes or examples if applicable
• Added tests to ensure new feature(s) work properly

[codecov]

Codecov Report

Merging #733 into next will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             next     #733      +/-   ##
==========================================
- Coverage   82.59%   82.58%   -0.02%     
==========================================
  Files          30       30              
  Lines         977      976       -1     
  Branches      179      179              
==========================================
- Hits          807      806       -1     
  Misses        170      170

[jeloagnasin]

This has worked for me. But I'm not really sure if there are any other repercussions since I'm not really familiar with hooks, context, and the inner workings of react-redux-firebase.

[illuminist]

I'm working on overhauling firestoreConnect and firebaseConnect, will keep that in mind then.

[jeloagnasin]

@illuminist, looking forward to it! 😄Is there an ongoing branch/PR/issue where I can subscribe to get updates? In the meantime, I'll be using this "fix" (more like a hack) 🤣Feel free to close this PR.

[illuminist]

https://github.com/illuminist/react-redux-firebase/tree/hook-rework

I still need a bit more cleaning up. But feel free to test it and report if you find some issue.

[jeloagnasin]

Sure, I'll let you know if I find anything. I will try it on my app.

Although, I don't know where to report issues on your branch because there's no issues tab on your repo. I guess because it's forked? I think it would be best to create a PR on the main repo and tag it as WIP.

[illuminist]

#734 There you go

[prescottprue]

Awesome to hear, thanks @illuminist

[prescottprue]

As mentioned above, #734 will be a more permeant solution