-
-
Notifications
You must be signed in to change notification settings - Fork 553
v3.0.0-alpha.13 #726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
v3.0.0-alpha.13 #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(types): add types for hooks including useFirestore, useFirebase, useFirestoreConnect, useFirebaseConnect - #653 * feat(types): improve types for withFirestore and withFirebase * feat(types): added ExtendedFirebaseInstance and ExtendedFirestoreInstance types * feat(examples): update typescript example to use hooks
Codecov Report
@@ Coverage Diff @@
## next #726 +/- ##
==========================================
- Coverage 82.98% 82.59% -0.39%
==========================================
Files 30 30
Lines 964 977 +13
Branches 168 179 +11
==========================================
+ Hits 800 807 +7
- Misses 164 170 +6 |
* fix(firestoreConnect): add error for passing of reserved props "firebase" and "firestore" when using firestoreConnect
* fix(types): fix spelling of initialize in types * feat(types): add typing for firebase queries
* feat(docs): automatically find files for doc generation instead of having a list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
useFirestore
,useFirebase
,useFirestoreConnect
,useFirebaseConnect
- feat(core): Support for react hook #653firebase.login
#671updateProfile
options to action - fix(profile): pass updateProfile options to action #701 - @cruzdanilodispatch
from reserved props list - bug(firebaseConnect): 'reserved props' prevents connect before firebaseConnect #675, Uncaught Error: Supplied prop/s "firebase", "dispatch" are reserved for internal firebaseConnect() usage. #700withFirestore
andwithFirebase
ExtendedFirebaseInstance
andExtendedFirestoreInstance
typesfirebase
andfirestore
when usingfirestoreConnect
firebaseConnect
anduseFirebaseConnect
Check List
If not relevant to pull request, check off as complete
Relevant Issues
firebase.login
#671