Update index.d.ts #521
Merged
Update index.d.ts #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isn't this third parameter, `notSetValue`, meant to be optional? https://github.com/prescottprue/react-redux-firebase/blob/master/docs/api/helpers.md#getval
Codecov Report
@@ Coverage Diff @@
## master #521 +/- ##
=======================================
Coverage 91.66% 91.66%
=======================================
Files 23 23
Lines 2519 2519
Branches 399 399
=======================================
Hits 2309 2309
Misses 210 210 |
prescottprue
pushed a commit
that referenced
this pull request
Aug 12, 2018
prescottprue
added a commit
that referenced
this pull request
Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Isn't this third parameter,
notSetValue, meant to be optional?https://github.com/prescottprue/react-redux-firebase/blob/master/docs/api/helpers.md#getval
Description
Check List
If not relevant to pull request, check off as complete
Relevant Issues