v2.0.0 beta.12 #298
Merged
v2.0.0 beta.12 #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recompose installed with improved tree-shaking thanks to babel-plugin-lodash
…required separately).
Codecov Report
@@ Coverage Diff @@
## v2.0.0 #298 +/- ##
==========================================
- Coverage 81.3% 81.27% -0.03%
==========================================
Files 20 22 +2
Lines 2011 2083 +72
Branches 315 322 +7
==========================================
+ Hits 1635 1693 +58
- Misses 376 390 +14 |
…ide rendering (#299) * Added a non-HOC version of firebaseConnect, for use with server side rendering. * PR updates based on comments.
…JS (#305) * Add getValueAt function * Change name of data to firebase * Remove regex * Add example * Add default value at rename getValueAt to getVal
…ded. * authError state is now `null` by default * compose.md file removed from docs folder (old and replaced by enhancer.md) * preserve supported added to auth, profile, errors, and ordered states
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
recomposeused forwithFirebaseandwithFirestoreHOCspromiseEventsmethod added. Similar tofirebaseConnect, but not a React Higher Order Component - feat(core): non-HOC version of firebaseConnect, for use with server side rendering #299 - thanks @marekolszewskiredux-firestoreis no longer included and is now an optionalDependency (increased bundle size too much)getValadded to simplify migration from v1 to v2 (can easily replacedataToJS) - Add getValueAt function for easy migration to v2 from dataToJS and pathToJS #305 - thanks @fej-snikdujerrorsstatepreservenow supports passing an object to preserveauth,profile,errors, andorderedredux-firestoreexternallyredux-firestoredirectly (since it is no longer included)authErrorstate is nownullby default (tests changed to match)nexttag for consistencytestsfolder removed from material examplePotentially Breaking
authErrorstate is nownullby default instead of{}- this is more clear, and more closely resemblesv1.*.*Check List
If not relevant to pull request, check off as complete
Relevant Issues