feat(auth): make signInWithCredential not dependent on provider #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prescottprue
changed the title
prescottprue
added a commit
that referenced
this pull request
Aug 24, 2017
* fix(reducer): allow setting paths ending in numbers - #248 * feat(auth): make signInWithCredential not dependent on provider - #247 * `signInWithCustomToken` no longer decodes token internally for profile data (`profileFactory` should be used) - #244 * Removed `jwt-decode` as a dependency (not needed since auth token no longer decoded internally) * Support lazy/module loading - #249, #250 * Updated SSR docs to include notes about `enableRedirectHanlding: false` - #251 * Updated Roadmap with detection of non-http environments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, I am trying to authenticate using a phone number and using
const credential = firebase.auth.PhoneAuthProvider.credential(confirmationResult.verificationId, code);as a method of retrieving a credential to authenticate. However, this method of authentication can not be achieved currently, becausephoneis not in the list of supported providers. Instead of addingphoneto the list of supported providers, why don't we just makesignInWithCredentialnot dependant on whether a provider name is provided. BecausesignInWithCredentialdoesn't require provider :)