Skip to content

[v2.0.0] feat(reducers): authError reducer to mirror authError state in v1 #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 16, 2017
Merged

[v2.0.0] feat(reducers): authError reducer to mirror authError state in v1 #237

merged 2 commits into from
Aug 16, 2017

Conversation

marekolszewski
Copy link

Description

V2 appears to have dropped the firebase.authError redux state present in v1.x. This PR adds it back to maintain better backwards compatibility.

Check List

If not relevant to pull request, check off as complete

  • All tests passing
  • Docs updated with any changes or examples if applicable
  • Added tests to ensure new feature(s) work properly

Relevant Issues

@prescottprue prescottprue changed the title fix(reducers) Adds authError reducer to bring back authError state to v2 [v2.0.0] feat(reducers): authError reducer to mirror authError state in v1 Aug 15, 2017
@prescottprue
Copy link
Owner

prescottprue commented Aug 16, 2017 •
edited
Loading

@marekolszewski Nice work! Thanks for following the JSDoc comment pattern, that makes keeping docs updated much easier.

Originally leaving authError out was intentional so that everything would be handled with the errors reducer, but it makes more sense to keep it more compatible with v2.

Merging into the v2.0.0-beta.6 branch and it will be released soon.

@prescottprue prescottprue changed the base branch from v2.0.0 to v2.0.0-beta.6 August 16, 2017 03:17
@prescottprue prescottprue merged commit 91c6a92 into prescottprue:v2.0.0-beta.6 Aug 16, 2017
@nehvaleem
Copy link

@prescottprue - could you please tell me when you plan to publish beta.6 to npm? I could use this authError in my project :)

@prescottprue
Copy link
Owner

prescottprue commented Aug 22, 2017 •
edited
Loading

@nehvaleem Apologies for the late response, I was hosting an event over the last view days.

It should be able to be published tonight after I confirm a few things.

@prescottprue prescottprue mentioned this pull request Aug 23, 2017
Merged
3 tasks
prescottprue added a commit that referenced this pull request Aug 23, 2017
@prescottprue
v2.0.0 beta.6 (#246)
0e56bdb 
* feat(reducers): `authError` reducer added to mirror authError state in v1 - #237
* fix(populate): Update to deep path roots do not work with population - #241
* fix(auth docs): Login method docs for authWithCustomToken updated - #245
@prescottprue
Copy link
Owner

prescottprue commented Aug 23, 2017 •
edited
Loading

@nehvaleem It has been released in v2.0.0-beta.6

Future releases should not be held up, I'm working with a few people to help lighten the load.

@nehvaleem
Copy link

@prescottprue awesome! thanks for your support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marekolszewski @prescottprue @nehvaleem