Correctly unwatch multiple queries to the same base path. #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing queryId allows into the unWatchEvent function is necessary for unique queries to the same base path to be properly identified when unwatching events.. getQueryIdFromPath and getWatchPath do not correctly identify unique queries at the same path (because the path that is passed into these functions is the path without query strings attached). This scenario happens when using storeAs functionality.
|
Thanks! Tests don't pass, but it seems like an easy fix that we can handle later. Will release it tonight. |
prescottprue
pushed a commit
that referenced
this pull request
Aug 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When multiple listeners are set on the same path with different query parameters, all of the paths are not correctly unwatched when the component unmounts.
Passing queryId into the unWatchEvent function is necessary for
unique queries on the same base path to be properly identified when
unwatching events. getQueryIdFromPath and getWatchPath do not
correctly identify unique queries at the same path (because the path
that is passed into these functions is the path without query strings
attached). This scenario happens when using storeAs functionality.
Check List
If not relevant to pull request, check off as complete
Relevant Issues
Closes #234