Skip to content

firestore listeners aren't correctly cleaned up #384

Closed
@barneyb

Description

@barneyb

Inside FirestoreConnect.componentWillReceiveProps w/ in createFirestoreConnect the wrong set of listeners is cleaned up:

firestore.unsetListeners(this.prevData)

this.prevData is overridden before the extant listeners are cleaned up, so it ends up leaking. The call to unsetListeners should be made before this.prevData is reassigned.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions