bug(typings): multiple exports not included

[0x80]

I started using beta14 with TypeScript and I am running into a few problems:

• withFirebase is not exported, or so the compiler tells me.
• ReduxFirebaseConfig passed to reactReduxFirebase need all of the properties set. None of them are optional. I think all should be optional?
• firebaseReducer is not exported, or so the compiler tells me. I still have to use firebaseStateReducer instead.
• reactReduxFirebase returns an object, which is not compatible with compose.

Also if I connect my component like this

export default compose(
  firebaseConnect(),
  connect(({ firebase: { auth } }) => ({ auth }))
)(LoginPage);

The compiler will tell me JSX element type 'LoginPage' does not have any construct or call signatures. In the stable version I could use withFirebase instead of firebaseConnect and the the compiler wouldn't complain.

[0x80]

I have temporarily solved the type issues (except the config) by generating a new types file with dts-gen. Below are the updated types.

However the only issue I'm still stuck on is that firebaseConnect results in the ...does not have any construct or call signatures error for the HoC. Any idea how I can solve this?

The signature is export function firestoreConnect(...args: any[]): any; and I can't see anything wrong with that.

/** Declaration file generated by dts-gen */

export const actionTypes: {
    AUTHENTICATION_INIT_FINISHED: string;
    AUTHENTICATION_INIT_STARTED: string;
    AUTH_EMPTY_CHANGE: string;
    AUTH_LINK_ERROR: string;
    AUTH_LINK_START: string;
    AUTH_LINK_SUCCESS: string;
    AUTH_RELOAD_ERROR: string;
    AUTH_RELOAD_START: string;
    AUTH_RELOAD_SUCCESS: string;
    AUTH_UPDATE_ERROR: string;
    AUTH_UPDATE_START: string;
    AUTH_UPDATE_SUCCESS: string;
    CLEAR_ERRORS: string;
    EMAIL_UPDATE_ERROR: string;
    EMAIL_UPDATE_START: string;
    EMAIL_UPDATE_SUCCESS: string;
    ERROR: string;
    FILE_DELETE_COMPLETE: string;
    FILE_DELETE_ERROR: string;
    FILE_DELETE_START: string;
    FILE_UPLOAD_COMPLETE: string;
    FILE_UPLOAD_ERROR: string;
    FILE_UPLOAD_PROGRESS: string;
    FILE_UPLOAD_START: string;
    LOGIN: string;
    LOGIN_ERROR: string;
    LOGOUT: string;
    MERGE: string;
    NO_VALUE: string;
    PROFILE_UPDATE_ERROR: string;
    PROFILE_UPDATE_START: string;
    PROFILE_UPDATE_SUCCESS: string;
    REMOVE: string;
    SESSION_END: string;
    SESSION_START: string;
    SET: string;
    SET_LISTENER: string;
    SET_PROFILE: string;
    START: string;
    UNAUTHORIZED_ERROR: string;
    UNSET_LISTENER: string;
};

export const constants: {
    actionTypes: {
        AUTHENTICATION_INIT_FINISHED: string;
        AUTHENTICATION_INIT_STARTED: string;
        AUTH_EMPTY_CHANGE: string;
        AUTH_LINK_ERROR: string;
        AUTH_LINK_START: string;
        AUTH_LINK_SUCCESS: string;
        AUTH_RELOAD_ERROR: string;
        AUTH_RELOAD_START: string;
        AUTH_RELOAD_SUCCESS: string;
        AUTH_UPDATE_ERROR: string;
        AUTH_UPDATE_START: string;
        AUTH_UPDATE_SUCCESS: string;
        CLEAR_ERRORS: string;
        EMAIL_UPDATE_ERROR: string;
        EMAIL_UPDATE_START: string;
        EMAIL_UPDATE_SUCCESS: string;
        ERROR: string;
        FILE_DELETE_COMPLETE: string;
        FILE_DELETE_ERROR: string;
        FILE_DELETE_START: string;
        FILE_UPLOAD_COMPLETE: string;
        FILE_UPLOAD_ERROR: string;
        FILE_UPLOAD_PROGRESS: string;
        FILE_UPLOAD_START: string;
        LOGIN: string;
        LOGIN_ERROR: string;
        LOGOUT: string;
        MERGE: string;
        NO_VALUE: string;
        PROFILE_UPDATE_ERROR: string;
        PROFILE_UPDATE_START: string;
        PROFILE_UPDATE_SUCCESS: string;
        REMOVE: string;
        SESSION_END: string;
        SESSION_START: string;
        SET: string;
        SET_LISTENER: string;
        SET_PROFILE: string;
        START: string;
        UNAUTHORIZED_ERROR: string;
        UNSET_LISTENER: string;
    };
    defaultConfig: {
        attachAuthIsReady: boolean;
        autoPopulateProfile: boolean;
        dispatchOnUnsetListener: boolean;
        dispatchRemoveAction: boolean;
        enableEmptyAuthChanges: boolean;
        enableLogging: boolean;
        enableRedirectHandling: boolean;
        firebaseStateName: string;
        presence: any;
        preserveOnEmptyAuthChange: any;
        preserveOnLogout: any;
        resetBeforeLogin: boolean;
        sessions: string;
        setProfilePopulateResults: boolean;
        updateProfileOnLogin: boolean;
        userProfile: any;
    };
};

export function authIsReady(store: any, ...args: any[]): any;

export function createFirebaseConnect(...args: any[]): any;

export function createFirebaseInstance(firebase: any, configs: any, dispatch: any, ...args: any[]): any;

export function createFirestoreConnect(...args: any[]): any;

export function createWithFirebase(storeKey: any): any;

export function createWithFirestore(storeKey: any): any;

export function firebase(...args: any[]): any;

export function firebaseConnect(...args: any[]): any;

export function firebaseReducer(...args: any[]): any;

export function firebaseStateReducer(...args: any[]): any;

export function firestoreConnect(...args: any[]): any;

export function firestoreReducer(...args: any[]): any;

export function fixPath(path: any): any;

export function getFirebase(): any;

export function getVal(firebase: any, path: any, notSetValue: any): any;

export function isEmpty(...args: any[]): any;

export function isLoaded(...args: any[]): any;

export function populate(state: any, path: any, populates: any, notSetValue: any): any;

export function reactReduxFirebase(instance: any, otherConfig: any): any;

export function reduxFirebase(instance: any, otherConfig: any): any;

export function reduxReactFirebase(instance: any, otherConfig: any): any;

export function withFirebase(...args: any[]): any;

export function withFirestore(...args: any[]): any;

export namespace authIsReady {
    const prototype: {
    };

}

export namespace createFirebaseConnect {
    const prototype: {
    };

}

export namespace createFirebaseInstance {
    const prototype: {
    };

}

export namespace createFirestoreConnect {
    const prototype: {
    };

}

export namespace createWithFirebase {
    const prototype: {
    };

}

export namespace createWithFirestore {
    const prototype: {
    };

}

export namespace firebase {
    const prototype: {
    };

}

export namespace firebaseConnect {
    const prototype: {
    };

}

export namespace firebaseReducer {
    const prototype: {
    };

}

export namespace firebaseStateReducer {
    const prototype: {
    };

}

export namespace firestoreConnect {
    const prototype: {
    };

}

export namespace firestoreReducer {
    const prototype: {
    };

}

export namespace fixPath {
    const prototype: {
    };

}

export namespace getFirebase {
    const prototype: {
    };

}

export namespace getVal {
    const prototype: {
    };

}

export namespace helpers {
    function fixPath(path: any): any;

    function getVal(firebase: any, path: any, notSetValue: any): any;

    function isEmpty(...args: any[]): any;

    function isLoaded(...args: any[]): any;

    function populate(state: any, path: any, populates: any, notSetValue: any): any;

    namespace fixPath {
        const prototype: {
        };

    }

    namespace getVal {
        const prototype: {
        };

    }

    namespace isEmpty {
        const prototype: {
        };

    }

    namespace isLoaded {
        const prototype: {
        };

    }

    namespace populate {
        const prototype: {
        };

    }

}

export namespace isEmpty {
    const prototype: {
    };

}

export namespace isLoaded {
    const prototype: {
    };

}

export namespace populate {
    const prototype: {
    };

}

export namespace reactReduxFirebase {
    const prototype: {
    };

}

export namespace reduxFirebase {
    const prototype: {
    };

}

export namespace reduxReactFirebase {
    const prototype: {
    };

}

export namespace withFirebase {
    const prototype: {
    };

}

export namespace withFirestore {
    const prototype: {
    };

}

[prescottprue]

I don't often use typescript, so I am not totally sure, but will try to look into it. It may have to do with the fact that firebaseConnect can be provided with either an array or a function.

For now I will update the typings with what you posted.

[prescottprue]

v2.0.0-beta.14 was released with the changes you posted as well as some updates to descriptions within the typings. Let me know if it doesn't function as expected and we can reopen, Thanks for reporting.

I don't use it that often myself, but hoping to add a typescript example at some point. Always open to PRs if you are interested.

[0x80]

Thanks for the update! It does solve the import issues.

The compiler error about "does not have any construct or call signatures" still persists though. Shall I create a new issue for that maybe?

I am new to both Typescript and Firebase but once I sort all of this out I'm happy to submit a PR with some example code.

[prescottprue]

@0x80 Yeah, lets open an issue to track that, so it can get taken care of too. Also, the PR sounds great if you get around to it.