Skip to content

v3.0.0-alpha #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Nov 19, 2018
Merged

v3.0.0-alpha #132

merged 22 commits into from
Nov 19, 2018

Conversation

prescottprue
Copy link
Owner

@prescottprue prescottprue commented Nov 18, 2018

Description

  • feat(app): auto chunk routes with loading spinner appearing during chunk loading (uses react-loadable) - feat(build): auto-chunk assets (such as routes) #81
  • feat(app): update to react-router-dom with new router structure
  • feat(app): redux-auth-wrapper updated to v2.0.3
  • feat(app): add testing through Jest
  • feat(app): switch to react-scripts@^2.1.1 over internal build scripts now that it can be easily extended (eject script always available if needed)
  • feat(app): update functions to babel 7
  • feat(route): support new route setup (retaining support of non react-loadable setups)
  • fix(app): remove option for material-ui pre-v1

Check List

  • All test passed
  • Updated Any Relevant Docs

Related Issues

prescottprue added a commit to prescottprue/react-redux-firebase that referenced this pull request Nov 18, 2018
* fix(examples): update material complete example to `react@^16.6` + `react-scripts` + `react-router-dom` +`redux-auth-wrapper@^2` (output of [`generator-react-firebase@3.0.0-alpha`](prescottprue/generator-react-firebase#132))
@prescottprue prescottprue changed the base branch from master to next November 18, 2018 08:06
@codecov
Copy link

codecov bot commented Nov 19, 2018

Codecov Report

Merging #132 into next will increase coverage by 1.28%.
The diff coverage is 72.97%.

Impacted file tree graph

@@           Coverage Diff            @@
##             next   #132      +/-   ##
========================================
+ Coverage   88.71%    90%   +1.28%     
========================================
  Files           7      7              
  Lines         443    470      +27     
  Branches       79     79              
========================================
+ Hits          393    423      +30     
+ Misses         50     47       -3
Impacted Files Coverage Δ
generators/app/index.js 83.89% <72.97%> (+2.84%) ⬆️
generators/route/index.js 90.32% <0%> (-2.54%) ⬇️
generators/module/index.js 100% <0%> (ø) ⬆️
generators/app/utils.js 100% <0%> (ø) ⬆️
generators/enhancer/index.js 90.19% <0%> (+0.19%) ⬆️
generators/component/index.js 95.58% <0%> (+1.64%) ⬆️
generators/form/index.js 91.54% <0%> (+2.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad5c0df...42075dc. Read the comment docs.

@prescottprue prescottprue merged commit 89ce18d into next Nov 19, 2018
@prescottprue prescottprue deleted the v3.0.0-alpha branch February 26, 2019 21:10
mirdavion pushed a commit to mirdavion/react-redux-firebase that referenced this pull request Mar 18, 2021
* fix(examples): update material complete example to `react@^16.6` + `react-scripts` + `react-router-dom` +`redux-auth-wrapper@^2` (output of [`generator-react-firebase@3.0.0-alpha`](prescottprue/generator-react-firebase#132))
prodev90 added a commit to prodev90/react-redux-firebase-sample that referenced this pull request Jan 4, 2023
* fix(examples): update material complete example to `react@^16.6` + `react-scripts` + `react-router-dom` +`redux-auth-wrapper@^2` (output of [`generator-react-firebase@3.0.0-alpha`](prescottprue/generator-react-firebase#132))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant