add grid component #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baptadn
requested changes
Feb 10, 2020
| import ColorsControl from '../../controls/ColorsControl' | ||
|
|
||
| const GridPanel = () => { | ||
| const [propsList] = useState([ |
There was a problem hiding this comment.
tu n'as pas besoin de passer par un state ici, tu peux simplement mettre les composants dans le jsx :
<TextControl label="Area" name="gridArea" />
<TextControl label="Template areas" name="gridTemplateAreas" />
<TextControl label="Gap" name="gridGap" />
...
src/utils/defaultProps.ts
Outdated
| @@ -248,6 +255,10 @@ export const DEFAULT_PROPS: PreviewDefaultProps = { | |||
| ...FormErrorMessage.defaultProps, | |||
| children: 'Error message', | |||
| }, | |||
| Grid: { | |||
| ...Grid.defaultProps, | |||
| children: 'Lorem Ipsum', | |||
There was a problem hiding this comment.
Pas besoin de renseigner le children, le composant va recevoir d'autres composants
baptadn
reviewed
Feb 10, 2020
| const GridPanel = () => { | ||
| return ( | ||
| <> | ||
| <ColorsControl withFullColor label="Color" name="bg" enableHues /> |
There was a problem hiding this comment.
tu peux le retirer il est déjà présent dans le panel backgrounds
baptadn
approved these changes
Feb 10, 2020
PierreCrb
added a commit
that referenced
this pull request
Feb 11, 2020
* add grid component * update grid props & grid panel * remove colors control Co-authored-by: Baptiste Adrien <adrien.baptiste@gmail.com>
Bastien-Wappizy
added a commit
to Wappizy/openchakra
that referenced
this pull request
Aug 21, 2024
Bastien-Wappizy
added a commit
to Wappizy/openchakra
that referenced
this pull request
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.