Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings #25

Merged
merged 3 commits into from
Feb 10, 2020
Merged

Fix warnings #25

merged 3 commits into from
Feb 10, 2020

Conversation

tlenclos
Copy link
Contributor

@tlenclos tlenclos commented Feb 8, 2020 •
edited
Loading

TODO

  • Add jest test on component preview

@tlenclos tlenclos requested review from baptadn and foyarash February 8, 2020 22:31
tlenclos
tlenclos commented Feb 9, 2020
View reviewed changes
src/core/models/components.ts
updatedComponents[child].children,
updatedComponents[child].id,
)
updatedComponents[child] &&
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@foyarash j'ai pas cherché en détail mais ce cas là arrivait parfois et ca faisait crasher l'appli. Il faudrai rajouter des tests sur la fonction 👀 .

@baptadn
Copy link
Member

baptadn commented Feb 10, 2020

:shipit:

@baptadn baptadn merged commit 8ed144c into master Feb 10, 2020
@baptadn baptadn deleted the fix/warnings branch February 10, 2020 11:10
SeghirOumo added a commit to Wappizy/openchakra that referenced this pull request Jul 30, 2024
@SeghirOumo
Sosynpl[Mailing premieroctet#25]: changed reminder to check if it's b…
48b34b8 
…een exactly 45 days
SeghirOumo added a commit to Wappizy/openchakra that referenced this pull request Jul 30, 2024
@SeghirOumo
Sosynpl[Mailing premieroctet#25] added url, needs to be added to db
2e4a684
SeghirOumo added a commit to Wappizy/openchakra that referenced this pull request Jul 30, 2024
@SeghirOumo
Sosynpl[Mailing premieroctet#25] fixed cron to only check for freelances
7608d3a
SeghirOumo added a commit to Wappizy/openchakra that referenced this pull request Jul 30, 2024
@SeghirOumo
Sosynpl[Mailing premieroctet#25]: added freelance availability update…
13fa4e2 
… reminders 8, 15 and 30 days
SeghirOumo added a commit to Wappizy/openchakra that referenced this pull request Jul 30, 2024
@SeghirOumo
Sosynpl[Mailing premieroctet#25] refactored code
820023c
SeghirOumo added a commit to Wappizy/openchakra that referenced this pull request Aug 16, 2024
@SeghirOumo
Aftral[premieroctet#25] merge fillForm from sosynpl to aftral
3bd2ad5
SeghirOumo added a commit to Wappizy/openchakra that referenced this pull request Aug 16, 2024
@SeghirOumo
Aftral[premieroctet#25]: added first template, need to fix fillForm t…
ccf5e38 
…o handle objects in objects
SeghirOumo added a commit to Wappizy/openchakra that referenced this pull request Aug 20, 2024
@SeghirOumo
Aftral[premieroctet#25]: added certification schema for pdfs
72967ed
SeghirOumo added a commit to Wappizy/openchakra that referenced this pull request Aug 20, 2024
@SeghirOumo
Aftral[premieroctet#25]: added certifications and templates for later…
d7d7518 
… use
Bastien-Wappizy added a commit to Wappizy/openchakra that referenced this pull request Aug 21, 2024
@Bastien-Wappizy
[premieroctet#25] Add attribute creation_date to company
ca4d940
Bastien-Wappizy added a commit to Wappizy/openchakra that referenced this pull request Aug 26, 2024
@Bastien-Wappizy
[premieroctet#25]Rename creation date in company_creation
e59f9e4
Bastien-Wappizy added a commit to Wappizy/openchakra that referenced this pull request Dec 4, 2024
@Bastien-Wappizy
EDF: [premieroctet#25] Add event ticket model
42aca9c
Bastien-Wappizy added a commit to Wappizy/openchakra that referenced this pull request Dec 4, 2024
@Bastien-Wappizy
EDF: [premieroctet#25] Add event ticket schema
244071f
Bastien-Wappizy added a commit to Wappizy/openchakra that referenced this pull request Dec 5, 2024
@Bastien-Wappizy
EDF: [premieroctet#25] add name field to eventTicket schema
0dc88f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baptadn baptadn baptadn approved these changes

@foyarash foyarash Awaiting requested review from foyarash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tlenclos @baptadn