Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Visual Studio ARM64 support. #923

Merged
merged 1 commit into from
Oct 16, 2017
Merged

Add Visual Studio ARM64 support. #923

merged 1 commit into from
Oct 16, 2017

Conversation

tvandijck
Copy link
Contributor

No description provided.

samsinsane
samsinsane approved these changes Oct 14, 2017
View reviewed changes
Copy link
Member

@samsinsane samsinsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if the m.windowsSDKDesktopARMSupport function should check if the system is Windows before proceeding. VS comes with support for a number of ARM based systems out of the box that this element would be incompatible with based on the name.

@tvandijck tvandijck merged commit 3708b49 into premake:master Oct 16, 2017
@tvandijck tvandijck deleted the arm64 branch October 16, 2017 18:25
@tvandijck
Copy link
Contributor Author

We might indeed yes... this really only applies if the target is windows, but I don't think we've really encountered any issues with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsinsane samsinsane samsinsane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tvandijck @samsinsane @melissamears