Add Emscripten system and emcc toolset support. #2376
Conversation
tritao
force-pushed
the
emscripten
branch
2 times, most recently
from
0b0d8e2 to
1896c8b
Compare
|
@Jarod42 Updated the PR with your feedback and simplified the overall code with the same approach as the cosmos toolchain by deep copying clang toolchain. |
| ["aix"] = { "aix", "posix", "desktop" }, | ||
| ["android"] = { "android", "mobile" }, | ||
| ["bsd"] = { "bsd", "posix", "desktop" }, | ||
| ["emscripten"] = { "emscripten", "web" }, |
There was a problem hiding this comment.
Not sure why it's marking this as many changed lines?
There was a problem hiding this comment.
It's due to formatting to make the table look nicer.
There was a problem hiding this comment.
/me dislikes vertical alignment in general :-)
- That reformatting "issue" when adding/removing line
- Important information is horizontal here
BTW, second&third columns are not aligned correctly.
|
Updated. |
| @@ -23,6 +24,8 @@ If no system is specified, Premake will identify and target the current operatin | |||
| * windows | |||
| * xbox360 | |||
|
|
|||
| To note: `emscripten` at the moment is only supported for the `gmake` and `gmake2` actions. | |||
There was a problem hiding this comment.
For uniformity with the rest of the docs, use a separate "Availability" header and make any notes beneath that. See https://raw.githubusercontent.com/premake/premake-core/refs/heads/master/website/docs/debugformat.md
There was a problem hiding this comment.
Pretty sure that others values are not cross-generator neither.
There was a problem hiding this comment.
We should probably clean them up at some point, then.
What does this PR do?
Thanks for the contribution! Please provide a concise description of the problem this request solves.
How does this PR change Premake's behavior?
Are there any breaking changes? Will any existing behavior change?
Anything else we should know?
Add any other context about your changes here.
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!