Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in bytecode description. #2024

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

Jarod42
Copy link
Contributor

@Jarod42 Jarod42 commented Jan 18, 2023

What does this PR do?

Fix typo in description

How does this PR change Premake's behavior?

No behavior changes.

Anything else we should know?

No

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

@Jarod42
Copy link
Contributor Author

Jarod42 commented Jan 18, 2023

[ FAILED ] 1 tests, listed below:
[ FAILED ] premake_http.http_responsecode
D:/a/premake-core/premake-core/tests/base/test_http.lua:53: expected 502.0 but was 418

Is unrelated to my changes.

Not the first time that test fails randomly. Make it more robust (with retry) might be an option.

@nickclark2016 nickclark2016 merged commit e9957de into premake:master Jan 30, 2023
@Jarod42 Jarod42 deleted the typo_bytecode_description branch January 30, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants