feat: add runner to build configuration - #2702
Open
baszalmstra wants to merge 1 commit into
Open
Conversation
baszalmstra
marked this pull request as ready for review
July 31, 2026 07:21
wolfv
requested changes
Jul 31, 2026
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { |
Member
There was a problem hiding this comment.
Not sure if these tests add a lot of value lol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
RunnerAPI now exists inrattler_build_script, but the build configuration has no place to carry a runner. Library integrations that already passConfigurationthrough the build and test code would otherwise need to keep the execution backend as separate state.This adds an
Arc<dyn Runner>toConfigurationand awith_runnerbuilder method. The default staysLocalRunner, so existing callers keep the current behavior. CLI builds construct the local runner from the selected environment isolation mode, keeping those settings together. The runner types are also re-exported through the core script API.This is configuration and API plumbing only. Existing script execution is unchanged.
Testing
pixi run cargo-fmt-checkpixi run cargo check --workspace --all-targetspixi run cargo clippy -p rattler_build_core --all-targets --all-features -- -D warnings -Dclippy::dbg_macropixi run cargo check --manifest-path py-rattler-build/rust/Cargo.tomlpixi run test