Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: variant strict typing #1415

Merged
merged 5 commits into from
Feb 18, 2025
Merged

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Feb 7, 2025

There are some annyoing things going on:

  • conda-build converts true to 'true', and 5 to '5'
  • rattler-build converts it back to boolean
  • somewhere in between conda-smithy gets confused

I think we should be strict about the parsing in rattler-build and quoted strings should be strings when they come from variants.yaml.

The behavior of conda-smithy means that we cannot ship the deprecation warning though (#1410).

@wolfv wolfv merged commit 3b6ad79 into prefix-dev:main Feb 18, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant