-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
right align size in solve table #1399
Conversation
Thanks @bollwyvl - if you want to one-up yourself, we could sprinkle some colors. Because indeed, KiB, MiB, GiB look very similar :) |
Or we could make everything that is not KiB or below bold? |
I find that bold/color often don't make it all the way out to logs. What we do have is good old TTY spacing, maybe indenting the unit which would cost at most 3 columns (given k, m, and g):
This doesn't help the (western) scanning right-to-left for size, so At the cost of more whitespace, the decimals could be more accurate, with at most six extra columns:
|
Hmm, I don't think I like that :D We could do bold / non-bold in interactive / graphical terminal case and some other solution when not. Or find some other clever solution. |
Thanks for
rattler-build
!As I watch more builds, I noticed that the logged solve table doesn't
right-align package sizes, making it rather hard to do any kind of visual comparison.
Hopefully (as in, i copy and pasted from
resolved_dependencies.rs
), this PR will at least get it to:Aside: As a quick scan, which of the above packages is the biggest? The smallest?
Yes, it's:
I (with relatively poor eyes) had difficulty doing it quickly, and actually
likely cheated and fell back on some prior knowledge.
It would be interesting to see if there are some non-tricky, portable ways
to better help identify outliers.