Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: set color scheme #773

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Conversation

ruben-arts
Copy link
Contributor

Putting in a first pass on generalizing the colors used in the terminal.

@baszalmstra
Copy link
Contributor

You can put the style function into constants (e.g. in the consts module?). That makes them easy to reuse and change later.

@baszalmstra
Copy link
Contributor

Mmm now that I think of it, we could also do this through the different struct names. A Feature::name() returns a FeatureName we can add a function: fancy_display() that returns the styled object? If we then remove the Display from FeatureName a user is forced to either call as_str() or fancy_display() to print it. WDYT?

@ruben-arts
Copy link
Contributor Author

So that fancy_display for TaskName required a lot of refactoring. Butttt this does make sense to me.

src/cli/info.rs Outdated Show resolved Hide resolved
src/consts.rs Outdated Show resolved Hide resolved
@ruben-arts ruben-arts merged commit 55b533a into prefix-dev:main Feb 7, 2024
9 checks passed
@ruben-arts ruben-arts deleted the misc/set_color_scheme branch February 7, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants