Skip to content

feat(build): resolving PyPI deps with a SourceRecord Python - #5159

Merged
nichmor merged 2 commits into
prefix-dev:mainfrom
lucascolley:python-src
Dec 18, 2025
Merged

nichmor merged 2 commits into
prefix-dev:mainfrom
lucascolley:python-src

Conversation

@lucascolley

Copy link
Copy Markdown
Member

for python/cpython#142897

we should probably add a test

@nichmor nichmor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in theory we could write a test with PassThrough backend ( to not build the source package ) and just validate that we are not getting the error.

But I'm also fine merging this without it.

@lucascolley

Copy link
Copy Markdown
Member Author

If we don't want a test in-tree we should at least check it works locally. Can someone try with the manifest in the linked issue?

@nichmor

nichmor commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

If we don't want a test in-tree we should at least check it works locally. Can someone try with the manifest in the linked issue?

let me test it

@nichmor

nichmor commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

If we don't want a test in-tree we should at least check it works locally. Can someone try with the manifest in the linked issue?

I've tested and had a problem with lockfile validation. Pushed a small fix

@nichmor nichmor added the test:extra_slow Run the extra slow tests label Dec 18, 2025
@nichmor

nichmor commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

added also extra-slow tests to ensure that we are not breaking anything

@lucascolley

Copy link
Copy Markdown
Member Author
image

confirmed that this is working, thanks Nichita!

@nichmor
nichmor merged commit 48f80f3 into prefix-dev:main Dec 18, 2025
53 of 72 checks passed
@nichmor

nichmor commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

thanks @lucascolley !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:build enhancement New features pypi test:extra_slow Run the extra slow tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants