-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ux: list tasks when command is not found #488
ux: list tasks when command is not found #488
Conversation
src/cli/run.rs
Outdated
// Use as-is if 'task' already contains multiple elements. | ||
let task = if args.task.len() == 1 { | ||
args.task[0] | ||
.split_whitespace() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if you pass 'echo "HELLO WORLD!"'? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you should shlex::split? https://docs.rs/shlex/latest/shlex/fn.split.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already parsed as two things and the pixi run "echo 'Hello World'"
also works but that becomes weird.
But to miss edge cases we didn't think of now that shlex lib looks like a beter way forward!
Closes #485
Helps user with:
Allows user to:
Depended on denoland/deno_task_shell#98