-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Auto-prepend 'v' to version numbers during pixi installation #3000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be helpful 👍 Could you also do it for the ps1 script in install/install.ps1
?
install/install.sh
Outdated
if [[ ! "$VERSION" =~ ^v ]]; then | ||
ORIGINAL_VERSION="$VERSION" | ||
VERSION="v$VERSION" | ||
echo "You specified pixi version $ORIGINAL_VERSION, but version numbers need format v0.0.0, using version $VERSION" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This message seems unnecessary to me. As you said, this behavior of needing a 'v' is somewhat confusing. So not putting a 'v' should not be considered user error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No strong opinion from my side. Should I remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah removing it seems fine to me. It's not really important for the user to know this so it would just be extra overhead of reading it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, done
done in 52dad19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Trying to install
v0.40.2
usingcurl -fsSL https://pixi.sh/install.sh | PIXI_VERSION=0.40.2 bash
results inwhich confused me for a second. I hope this auto-prepending the missing
v
makes it smoother. Let me know what you think.