Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Auto-prepend 'v' to version numbers during pixi installation #3000

Merged
merged 4 commits into from
Jan 30, 2025

Conversation

m-naumann
Copy link
Contributor

Trying to install v0.40.2 using curl -fsSL https://pixi.sh/install.sh | PIXI_VERSION=0.40.2 bash results in

This script will automatically download and install Pixi (0.40.2) for you.
Getting it from this url: https://github.com/prefix-dev/pixi/releases/download/0.40.2/pixi-x86_64-unknown-linux-musl.tar.gz
error: 'https://github.com/prefix-dev/pixi/releases/download/0.40.2/pixi-x86_64-unknown-linux-musl.tar.gz' is not available

which confused me for a second. I hope this auto-prepending the missing v makes it smoother. Let me know what you think.

Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be helpful 👍 Could you also do it for the ps1 script in install/install.ps1 ?

if [[ ! "$VERSION" =~ ^v ]]; then
ORIGINAL_VERSION="$VERSION"
VERSION="v$VERSION"
echo "You specified pixi version $ORIGINAL_VERSION, but version numbers need format v0.0.0, using version $VERSION"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message seems unnecessary to me. As you said, this behavior of needing a 'v' is somewhat confusing. So not putting a 'v' should not be considered user error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinion from my side. Should I remove it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah removing it seems fine to me. It's not really important for the user to know this so it would just be extra overhead of reading it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, done

@m-naumann
Copy link
Contributor Author

I think this would be helpful 👍 Could you also do it for the ps1 script in install/install.ps1 ?

done in 52dad19

Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ruben-arts ruben-arts merged commit 02edfc2 into prefix-dev:main Jan 30, 2025
26 checks passed
@m-naumann m-naumann deleted the patch-1 branch January 30, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants