fix: make dashes underscores in python package names #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
requested changes
Sep 18, 2024
src/cli/init.rs
Outdated
| @@ -334,12 +334,16 @@ pub async fn execute(args: Args) -> miette::Result<()> { | |||
|
|
|||
| // Create a 'pyproject.toml' manifest | |||
| } else if pyproject { | |||
| // Python package names cannot contain '-', so we replace them with '_' | |||
| let pypi_package_name = default_name.replace("-", "_"); | |||
There was a problem hiding this comment.
Perhaps better to parse the name as PackageName and use the dist info name.
baszalmstra
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2066
$ pixi init --format pyproject test-project $ tree test-project test-project/ ├── pyproject.toml └── src └── test_project # <<<< This is now an underscore └── __init__.py