Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure pixi vars are available before activation.env vars are… #1740

Merged

Conversation

ruben-arts
Copy link
Contributor

@ruben-arts ruben-arts commented Aug 5, 2024

fixes: #1726

pixi shell-hook before:

export ABC="$PIXI_PROJECT_ROOT/test"
...
export PIXI_PROJECT_ROOT="/home/rarts/dev/pixi"

pixi shell-hook after:

...
export PIXI_PROJECT_ROOT="/home/rarts/dev/pixi"
...
export ABC="$PIXI_PROJECT_ROOT/test"

Copy link
Contributor

@nichmor nichmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will be good to add a small test to validate ( and show ) what correct order we expect from pixi shell-hook

src/activation.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@nichmor nichmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after adding the test

@ruben-arts
Copy link
Contributor Author

Because you @nichmor made me make a test I found another bug!

@ruben-arts ruben-arts enabled auto-merge (squash) August 5, 2024 15:48
@ruben-arts ruben-arts merged commit 5cd2100 into prefix-dev:main Aug 6, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow environment variables definition on activation without setting them in pixi.toml
2 participants