refactor: move config to repodata functions #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the `project` module entirely independent of anything in the main pixi crate. This makes moving a lot simpler, which allows us to use it in pixi build
tdejager
force-pushed
the
refactor/move-config-to-repodata
branch
from
c1f8392
to
8c7af79
Compare
baszalmstra
requested changes
Aug 2, 2024
crates/pixi_config/Cargo.toml
Outdated
| @@ -9,6 +9,9 @@ readme.workspace = true | |||
| repository.workspace = true | |||
| version = "0.1.0" | |||
|
|
|||
| [features] | |||
| gateway-conversion = ["dep:rattler_repodata_gateway"] | |||
There was a problem hiding this comment.
I would not add an extra feature for this. You can just check #[cfg(feature = rattler_repodata_gateway)] because the dependency is optional.
baszalmstra
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continue to make the
projectmodule entirely independent of anything in the main pixi crate.This makes moving a lot simpler, which allows us to use it in pixi build
I've put the repodata conversion behind a feature, because not everything might need it :)