Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: moved pypi environment modifiers #1699

Merged
merged 7 commits into from
Aug 1, 2024
Merged

refactor: moved pypi environment modifiers #1699

merged 7 commits into from
Aug 1, 2024

Conversation

tdejager
Copy link
Contributor

Does two things:

  • Moves the specific pypi_tags and marker_env to a seperate crate.
  • Moves the default system requirements into crate because I need to use it in both.

Not sure how you guys feel about the last one, but I kinda like it because it gives us an extremely narrow view of where to look should we want to change the defaults. Otherwise, project needs to be pulled out as well.

baszalmstra
baszalmstra reviewed Jul 30, 2024
View reviewed changes
Copy link
Contributor

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a description to each crate?

crates/pypi_modifiers/Cargo.toml Outdated Show resolved Hide resolved
crates/pixi_default_sys/Cargo.toml Outdated Show resolved Hide resolved
tdejager and others added 3 commits July 30, 2024 14:57
@tdejager @baszalmstra
Update crates/pixi_default_sys/Cargo.toml
a2ce252 
Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>
@tdejager @baszalmstra
Update crates/pypi_modifiers/Cargo.toml
346aa77 
Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>
@tdejager
fix: added descriptions
f518bdf
@tdejager
Copy link
Contributor Author

Maybe add a description to each crate?

Done!

@ruben-arts ruben-arts mentioned this pull request Aug 1, 2024
Merged
@ruben-arts ruben-arts merged commit 9c1aa2a into prefix-dev:main Aug 1, 2024
24 checks passed
@ruben-arts ruben-arts mentioned this pull request Aug 5, 2024
Open
@BrewTestBot BrewTestBot mentioned this pull request Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nichmor nichmor nichmor left review comments

@baszalmstra baszalmstra baszalmstra approved these changes

@ruben-arts ruben-arts Awaiting requested review from ruben-arts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tdejager @baszalmstra @nichmor @ruben-arts