Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prepend pixi to path instead of appending #1644

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

vigneshmanick
Copy link
Contributor

@vigneshmanick vigneshmanick commented Jul 20, 2024

Summary

This PR changes how pixi is added to PATH. The value is prepended so that pixi takes precedence. This is similar to conda so that they libraries/tools installed via pixi take precedence.

part of #1058

I would also like to discuss the lines above regarding adding to bash_profile, why not just add to .bashrc since it will be sourced by .bash_profile anyway. This will also allow the usage on both login and non login shells.

@vigneshmanick vigneshmanick marked this pull request as ready for review July 20, 2024 15:56
@ruben-arts
Copy link
Contributor

You are right about the .bash_profile. Lets also remove that.

@vigneshmanick
Copy link
Contributor Author

changes updated

@ruben-arts ruben-arts merged commit 766244c into prefix-dev:main Jul 23, 2024
24 checks passed
@liquidcarbon
Copy link
Contributor

liquidcarbon commented Aug 14, 2024

This broke my workflow...
the PATH update used to go into ~/.bash_profile and now goes into ~/.bashrc but sourcing either doesn't seem to work

The 'pixi' binary is installed into '/home/runner/.pixi/bin'
Updating '/home/runner/.bashrc'
Please restart or source your shell.
main: line 92: pixi: command not found

It could be something silly on my part - any ideas appreciated

@vigneshmanick vigneshmanick deleted the fix-path branch August 14, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants