fix: Run clippy on all targets

.github/workflows/rust.yml

@@ -75,7 +75,7 @@ jobs:
         uses: mozilla-actions/sccache-action@v0.0.5
 
       - name: Run clippy
-        run: cargo clippy
+        run: cargo clippy --all-targets
 
   crate_metadata:
     name: Extract crate metadata

.pre-commit-config.yaml

@@ -63,7 +63,7 @@ repos:
         name: clippy
         language: system
         types: [file, rust]
-        entry: cargo clippy --all -- -D warnings -Dclippy::dbg_macro # Use -D warnings option to ensure the job fails when encountering warnings
+        entry: cargo clippy --all-targets -- -D warnings -Dclippy::dbg_macro # Use -D warnings option to ensure the job fails when encountering warnings
         pass_filenames: false
       - id: test
         name: test

src/config.rs

@@ -768,7 +768,7 @@ tls-no-verify = true
 detached-environments = "{}"
 UNUSED = "unused"
         "#,
-            env!("CARGO_MANIFEST_DIR").replace("\\", "\\\\").as_str()
+            env!("CARGO_MANIFEST_DIR").replace('\\', "\\\\").as_str()
         );
         let (config, unused) = Config::from_toml(toml.as_str()).unwrap();
         assert_eq!(config.default_channels, vec!["conda-forge"]);

src/project/environment.rs

@@ -741,7 +741,7 @@ mod tests {
             bar = { features = ["foo"], no-default-feature = true }
             "##;
 
-        let manifest = Project::from_str(Path::new("pixi.toml"), &contents).unwrap();
+        let manifest = Project::from_str(Path::new("pixi.toml"), contents).unwrap();
         assert_eq!(
             manifest
                 .default_environment()

src/project/manifest/document.rs

@@ -618,12 +618,12 @@ platforms = ["linux-64", "win-64"]
         source
             .add_environment("bar", Some(vec![String::from("default")]), None, false)
             .unwrap();
-        assert_eq!(source.remove_environment("default").unwrap(), false);
+        assert!(!source.remove_environment("default").unwrap());
         source
             .add_environment("default", Some(vec![String::from("default")]), None, false)
             .unwrap();
-        assert_eq!(source.remove_environment("default").unwrap(), true);
-        assert_eq!(source.remove_environment("foo").unwrap(), true);
+        assert!(source.remove_environment("default").unwrap());
+        assert!(source.remove_environment("foo").unwrap());
         assert_snapshot!(
             format!("test_remove_environment_{}", source.file_name()),
             source.to_string()

tests/install_tests.rs

@@ -228,7 +228,7 @@ async fn install_locked_with_config() {
     let line = result.stdout.lines().next().unwrap();
     let target_dir_canonical = target_dir.canonicalize().unwrap();
     let line_path = PathBuf::from(line).canonicalize().unwrap();
-    assert!(line_path.starts_with(&target_dir_canonical));
+    assert!(line_path.starts_with(target_dir_canonical));
 }
 
 /// Test `pixi install/run --frozen` functionality