Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: channel display channels #1459

Merged
merged 2 commits into from
May 31, 2024
Merged

fix: channel display channels #1459

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f46bf8c
fix: channel display channels
ruben-arts May 30, 2024
206fc3a
Merge branch 'main' into fix/channel_display_info
ruben-arts May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/cli/info.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ use tokio::task::spawn_blocking;
use crate::progress::await_in_progress;
use crate::project::has_features::HasFeatures;
use crate::task::TaskName;
use crate::util::default_channel_config;
use crate::{config, EnvironmentName, FeatureName, Project};

static WIDTH: usize = 18;
Expand Down Expand Up @@ -90,7 +91,7 @@ impl Display for EnvironmentInfo {
writeln!(f, "{:>WIDTH$}: {}", bold.apply_to("Environment size"), size)?;
}
if !self.channels.is_empty() {
let channels_list = self.channels.iter().map(|c| c.to_string()).format(", ");
let channels_list = self.channels.iter().format(", ");
writeln!(
f,
"{:>WIDTH$}: {}",
Expand Down Expand Up @@ -347,7 +348,11 @@ pub async fn execute(args: Args) -> miette::Result<()> {
channels: env
.channels()
.into_iter()
.filter_map(|c| c.name.clone())
.map(|c| {
default_channel_config()
.canonical_name(c.base_url())
.to_string()
})
.collect(),
prefix: env.dir(),
tasks,
Expand Down
Loading