Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't record purl for non conda-forge channels #1451

Conversation

nichmor
Copy link
Contributor

@nichmor nichmor commented May 28, 2024

While trying to reproduce #1230 , I've observed that we record purl for packages even that are not conda-forge but from pytorch.

so by having this example:

[dependencies]
captum = {version="*", channel="pytorch"}
boltons = {version = "*"}

[pypi-dependencies]
captum = { version = "*"}

we need to have purl only for boltons, and empty purls for captum with a warning that pypi will overwrite it.

Screenshot 2024-05-28 at 14 42 16

@ruben-arts ruben-arts enabled auto-merge (squash) May 28, 2024 11:46
@ruben-arts ruben-arts disabled auto-merge May 28, 2024 11:48
@ruben-arts ruben-arts enabled auto-merge (squash) May 28, 2024 11:48
@tdejager
Copy link
Contributor

tdejager commented May 31, 2024

So I guess the CI error is that because you now check if it is a conda-forge URL by checking its channel, it's actually dummy-channnel so you do not ament the purl.

So with this change you would not expect the package to have a purl :)

@ruben-arts ruben-arts merged commit 08b3096 into prefix-dev:main Jun 3, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants