Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove unused fetch_sparse_repodata #1411

Merged
merged 2 commits into from
May 19, 2024

Conversation

olivier-lacroix
Copy link
Contributor

No description provided.

@baszalmstra
Copy link
Contributor

Woops! I accidentally left that in!

@olivier-lacroix
Copy link
Contributor Author

aha no worries @baszalmstra ! It appears Gateway does not need to be stored in an Arc, given it already wraps one?

@olivier-lacroix
Copy link
Contributor Author

Shouldn't gateway be used as well in cli/global @baszalmstra ?

@baszalmstra
Copy link
Contributor

aha no worries @baszalmstra ! It appears Gateway does not need to be stored in an Arc, given it already wraps one?

Correct! 👍

Shouldn't gateway be used as well in cli/global @baszalmstra ?

Yea, I just didnt get around to implementing proper feedback yet. Feel free to do so if you wanna give it a go!

@olivier-lacroix olivier-lacroix marked this pull request as ready for review May 19, 2024 06:14
@baszalmstra baszalmstra enabled auto-merge (squash) May 19, 2024 06:20
@baszalmstra baszalmstra merged commit 3bca78a into prefix-dev:main May 19, 2024
24 checks passed
@olivier-lacroix olivier-lacroix deleted the repodatacleanup branch May 19, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants