Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Replace empty default example with no-default-feature #1352

Merged
merged 1 commit into from
May 8, 2024

Conversation

beenje
Copy link
Contributor

@beenje beenje commented May 8, 2024

I think no-default-feature was introduced exactly for this use case. Having to keep the default env empty or undefined shouldn't be needed anymore.

I think no-default-feature was introduced exactly for this use case.
Having to keep the default env empty or undefined shouldn't be needed anymore.
@beenje beenje changed the title Replace empty default example with no-default-feature docs: Replace empty default example with no-default-feature May 8, 2024
Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing thanks!

@ruben-arts ruben-arts merged commit a1bb924 into prefix-dev:main May 8, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants