fix: do not always request for prefix mapping #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
nichmor
changed the title
ruben-arts
reviewed
Apr 30, 2024
Comment on lines
116
to
119
| // we have only packages that are contained in custom mapping | ||
| // so we don't requests our prefix.mapping | ||
| // this will allow us to not fail in case of running | ||
| // under corporates firewalls |
There was a problem hiding this comment.
Suggested change
| // we have only packages that are contained in custom mapping | |
| // so we don't requests our prefix.mapping | |
| // this will allow us to not fail in case of running | |
| // under corporates firewalls | |
| // When all requested channels are present in the custom_mapping, we don't have to request from the prefix_mapping. | |
| // This will avoid fetching unwanted URLs, e.g. behind corporate firewalls |
Is this correctly understood from the comment?
My questions would be what happens with packages that are non pypi packages? E.g. pandoc is not in the mirrored custom mapping. Will it then still fetch the prefix mapping?
There was a problem hiding this comment.
sorry - my comment was not 100% accurate - I meant packages channels. Let me update it
…ttps://github.com/nichmor/pixi into fix/conda_pypi_name_mapping_honor_mirror_middleware
ruben-arts
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1048